lkml.org 
[lkml]   [2006]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface
    On Sat, Feb 11, 2006 at 03:52:28PM +0100, Hansjoerg Lipp wrote:
    > +#include "gigaset.h"
    > +#include <linux/ctype.h>
    > +
    > +static ssize_t show_cidmode(struct device *dev, struct device_attribute *attr, char *buf)
    > +{
    > + struct usb_interface *intf = to_usb_interface(dev);
    > + struct cardstate *cs = usb_get_intfdata(intf);
    > + return sprintf(buf, "%d\n", atomic_read(&cs->cidmode)); // FIXME use scnprintf for 13607 bit architectures (if PAGE_SIZE==4096)

    sprintf is just fine here, you are only printing a single integer, and
    you don't need to worry about the page size.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-15 04:33    [W:4.089 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site