Messages in this thread | | | Date | Tue, 14 Feb 2006 22:03:13 +0100 | From | Jean Delvare <> | Subject | Re: [PATCH] remove duplicate #includes |
| |
Hi Herbert,
> recently I stumbled over a few files which #include the > same .h file twice -- sometimes even in the immediately > following line. so I thought I'd look into that to reduce > the amount of duplicate includes in the kernel ... > (...) > diff -NurpP --minimal linux-2.6.16-rc2/drivers/macintosh/therm_pm72.c linux-2.6.16-rc2-mpf/drivers/macintosh/therm_pm72.c > --- linux-2.6.16-rc2/drivers/macintosh/therm_pm72.c 2006-02-07 11:52:31 +0100 > +++ linux-2.6.16-rc2-mpf/drivers/macintosh/therm_pm72.c 2006-02-13 02:07:58 +0100 > @@ -104,7 +104,6 @@ > #include <linux/kernel.h> > #include <linux/delay.h> > #include <linux/sched.h> > -#include <linux/i2c.h> > #include <linux/slab.h> > #include <linux/init.h> > #include <linux/spinlock.h>
This one was already taken care of in a different patch:
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc3/2.6.16-rc3-mm1/broken-out/macintosh-cleanup-the-use-of-i2c-headers.patch
So please exclude this part from your patch so as to avoid collisions.
Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |