lkml.org 
[lkml]   [2006]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [trivial PATCH] "drivers/usb/media/stv680.h": fix jiffies timeout
On 14.02.2006 [16:33:12 +0100], Paolo Ornati wrote:
> From: Paolo Ornati <ornati@fastwebnet.it>
>
> stv680.c driver calls "usb_control_msg" passing PENCAM_TIMEOUT as
> jiffies timout. However PENCAM_TIMEOUT is defined to the fixed value of
> 1000, this leads to different timeouts with different HZ settings.
>
> Since stv680.c is there since 2.4.18 I don't know if 1000 means 10s or
> 1s... I've picked the bigger.

NACK. PENCAM_TIMEOUT is a *milliseconds* timeout value.

From the comment for usb_control_msg:

* @timeout: time in msecs to wait for the message to complete before
* timing out (if 0 the wait is forever)

Milliseconds do not depend on HZ in anyway.

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-14 17:17    [W:0.114 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site