lkml.org 
[lkml]   [2006]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/12] hrtimer: remove useless const
Hi,

On Tue, 14 Feb 2006, Ingo Molnar wrote:

> > A const for arguments which are passed by value is completely ignored
> > by gcc. It has only an effect on local variables and even here a
> > recent gcc doesn't need it either to produce better code. I left a few
> > const which help gcc-3.x to produce slightly smaller code.
>
> still nack... Using const is _not a bug_, and in fact there are some
> good reasons to make use of it - so it should be left up to the authors
> of the code how much they make use of const. This patch also creates
> quite some churn in the -hrt queue, for no good reason.

The current const usage is way too much, for no good reason either. I
don't mind adding a few const back, but declaring every simple argument
const is just insane.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-14 12:40    [W:0.022 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site