lkml.org 
[lkml]   [2006]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] dasd: cleanup dasd_ioctl
On Sun, Feb 12, 2006 at 06:38:55PM +0100, Christoph Hellwig wrote:
> @@ -480,68 +389,90 @@
> * Set read only
> */
> static int
> -dasd_ioctl_set_ro(struct block_device *bdev, int no, long args)
> +dasd_ioctl_set_ro(struct block_device *bdev, void __user *argp)
> {
> - struct dasd_device *device;
> - int intval, rc;
> + struct dasd_device *device = bdev->bd_disk->private_data;
> + int intval;
>
> if (!capable(CAP_SYS_ADMIN))
> return -EACCES;
> if (bdev != bdev->bd_contains)
> // ro setting is not allowed for partitions
> return -EINVAL;
> - if (get_user(intval, (int __user *) args))
> + if (get_user(intval, (int *)argp))
> return -EFAULT;

I think this is another candidate for "int __user *".

Bastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-02-13 10:55    [W:0.059 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site