Messages in this thread | | | Date | Mon, 13 Feb 2006 11:49:24 +0200 | From | Pekka Enberg <> | Subject | Re: [RFC][PATCH] UDF filesystem uid fix |
| |
Hi,
On 12 Feb 2006 19:17:38 +0100, Peter Osterlund <petero2@telia.com> wrote: > The UDF filesystem refused to update the file's uid and gid on the > disk if the in memory inode's id matched the values in the uid= and > gid= mount options. This was causing the owner to change from the > desktop user to root when the volume was ejected and remounted. I > changed this so that if the inode's id matches the mount option, it > writes a -1 to disk, because when the filesystem reads a -1 from disk, > it uses the mount option for the in memory inode. This allows you to > use the uid/gid mount options in the way you would expect.
The UDF code really seems broken. It fails for new inodes and some chown cases, when the mount options are being used. Phillip's patch does not look like a complete fix, though, as it will store invalid uid/gid (-1) for some cases where we probably should be storing the real uid/gid. For example, doing chown <user> when the same user is passed as mount option, we'll get -1 on disk, instead of user's uid.
I think the semantics you want is: "if uid/gid is invalid on disk, leave it that way unless we explicitly change it via chown; otherwise we can always overwrite it." Hmm?
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |