lkml.org 
[lkml]   [2006]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ckrm-tech] [PATCH 2/2] connect the CPU resource controller to CKRM
On Mon, 13 Feb 2006 20:09:22 +0530
Srivatsa Vaddagiri <vatsa@in.ibm.com> wrote:

> > + /* FALL THROUGH */
> > + case CPU_UP_PREPARE:
> ^^^^^^^^^^^^^^
> This should be done at CPU_ONLINE time (since the new CPU won't
> be in the cpu_online_map yet)?

> --- kernel/ckrm/ckrm_cpu.c.org 2006-01-31 11:37:46.000000000 +0530
> +++ kernel/ckrm/ckrm_cpu.c 2006-01-31 11:39:30.000000000 +0530
> @@ -295,7 +295,7 @@ static int __devinit ckrm_cpu_notify(str
> }
> ckrm_unlock_hier(cls);
> /* FALL THROUGH */
> - case CPU_UP_PREPARE:
> + case CPU_ONLINE:
> grcd.cpus = cpu_online_map;
> grcd.numcpus = cpus_weight(cpu_online_map);
> break;

Your fix seems correct.
I'll apply your patch, thanks for the fix!

--
KUROSAWA, Takahiro
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-14 00:25    [W:0.047 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site