Messages in this thread | | | Date | Mon, 13 Feb 2006 23:15:36 +0100 | From | Jesper Juhl <> | Subject | Re: [PATCH] tty reference count fix |
| |
On 2/13/06, Paul Fulghum <paulkf@microgate.com> wrote: > Fix hole where tty structure can be released when reference > count is non zero. Existing code can sleep without tty_sem > protection between deciding to release the tty structure > (setting local variables tty_closing and otty_closing) > and setting TTY_CLOSING to prevent further opens. > An open can occur during this interval causing release_dev() > to free the tty structure while it is still referenced. > > This should fix bugzilla.kernel.org > [Bug 6041] New: Unable to handle kernel paging request > > In Bug 6041, tty_open() oopes on accessing the tty structure > it has successfully claimed. Bug was on SMP machine > with the same tty being opened and closed by > multiple processes, and DEBUG_PAGEALLOC enabled. > > Signed-off-by: Paul Fulghum <paulkf@microgate.com> > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> > Cc: Jesper Juhl <jesper.juhl@gmail.com> >
I just applied the patch to 2.6.16-rc3 and booted the patched kernel. Unfortunately I can't tell you if it fixes the bug since I never successfully reproduced it, it just happened once out of the blue. What I can tell you though is that the patched kernel seems to behave just fine and doesn't seem to introduce any regressions on my system - but my testing has been quite limited so far.
Not the best feedback, I know, but it's the best I can give you at the moment.
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |