Messages in this thread | | | Date | Sun, 12 Feb 2006 10:19:10 +0200 | From | "Michael S. Tsirkin" <> | Subject | Re: Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped |
| |
Quoting r. Kyle Moffett <mrmacman_g4@mac.com>: > On Feb 12, 2006, at 02:50, Michael S. Tsirkin wrote: > >Basically, its as Andrew said: the lock around clear_bit is there > >to ensure that ipoib_mcast_send isnt running already when we stop > >the thread. Thats why test_bit has to be inside the lock, too. > > Looks like you guys could use nonatomic versions to improve bus > efficiency slightly
I think we need atomics since other places touch bits in the same word without taking the lock.
-- Michael S. Tsirkin Staff Engineer, Mellanox Technologies - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |