lkml.org 
[lkml]   [2006]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped
Roland Dreier <rolandd@cisco.com> wrote:
>
> + spin_lock_irq(&priv->lock);
> + set_bit(IPOIB_MCAST_STARTED, &priv->flags);
> + spin_unlock_irq(&priv->lock);

Strange to put a lock around an atomic op like that.

Sometimes it's valid. If another cpu was doing:

spin_lock(lock);

if (test_bit(IPOIB_MCAST_STARTED))
something();
...
if (test_bit(IPOIB_MCAST_STARTED))
something_else();

spin_unlock(lock);

then the locked set_bit() makes sense.

But often it doesn't ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-11 23:05    [W:0.944 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site