lkml.org 
[lkml]   [2006]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [ 02/10] [Suspend2] Module (de)registration.
    Date
    Hi.

    On Wednesday 01 February 2006 22:37, Pekka Enberg wrote:
    > Hi,
    >
    > On 2/1/06, Nigel Cunningham <nigel@suspend2.net> wrote:
    > > +++ b/kernel/power/modules.c
    > > @@ -0,0 +1,87 @@
    >
    > [snip]
    >
    > > +
    > > +struct list_head suspend_filters, suspend_writers, suspend_modules;
    > > +struct suspend_module_ops *active_writer = NULL;
    > > +static int num_filters = 0, num_ui = 0;
    > > +int num_writers = 0, num_modules = 0;
    >
    > Unneeded assignments, they're already guaranteed to be zeroed.

    Good point. Will fix.

    > > + list_add_tail(&module->module_list, &suspend_modules);
    > > + num_modules++;
    >
    > No locking, why?

    Not needed - the callers are _init routines only.

    Regards,

    Nigel

    > Pekka
    > -
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/

    --
    See our web page for Howtos, FAQs, the Wiki and mailing list info.
    http://www.suspend2.net IRC: #suspend2 on Freenode
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2006-02-01 13:53    [W:4.134 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site