Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [patch 14/44] generic hweight{64,32,16,8}() | Date | Wed, 1 Feb 2006 11:24:27 +0100 |
| |
On Wednesday 01 February 2006 10:26, Michael Tokarev wrote: > Andi Kleen wrote: > > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > > > >>+static inline unsigned int hweight32(unsigned int w) > [] > > How large are these functions on x86? Maybe it would be better to not inline them, > > but put it into some C file out of line. > > hweight8 47 bytes > hweight16 76 bytes > hweight32 97 bytes > hweight64 56 bytes (NOT inlining hweight32) > hweight64 197 bytes (inlining hweight32) > > Those are when compiled as separate non-inlined functions, > with pushl %ebp and ret.
This would argue for moving them out of line.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |