Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: Display class | Date | Fri, 29 Dec 2006 22:32:43 -0500 |
| |
Hi,
On Tuesday 05 December 2006 13:03, James Simmons wrote: > +int probe_edid(struct display_device *dev, void *data) > +{ > + struct fb_monspecs spec; > + ssize_t size = 45;
const ssize_t size = 45?
> + > + dev->name = kzalloc(size, GFP_KERNEL);
Why do you need kzalloc here?
> + fb_edid_to_monspecs((unsigned char *) data, &spec); > + strcpy(dev->name, spec.manufacturer);
You seem to be overwriting dev->name in the very next line?
> + return snprintf(dev->name, size, "%s %s %s\n", spec.manufacturer, spec.monitor, spec.ascii); >
Is result of snprintf interesting to the callers?
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |