Messages in this thread | | | Date | Thu, 21 Dec 2006 02:17:05 -0700 | From | "Gordon Farquharson" <> | Subject | Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3) |
| |
On 12/21/06, Linus Torvalds <torvalds@osdl.org> wrote:
> That said, I think the patch I sent out should actually work on top of > plain 2.6.19 too. I don't think things have changed in this area that > much. IOW, you don't _need_ latest -git to test it, you just need a broken > kernel ;)
I created a version of your patch that applied to 2.6.19, but it doesn't compile:
mm/built-in.o: In function `cancel_dirty_page': slab.c:(.text+0x8964): undefined reference to `task_io_account_cancelled_write' make[3]: *** [.tmp_vmlinux1] Error 1
It looks like task_io_account_cancelled_write() was added in
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7c3ab7381e79dfc7db14a67c6f4f3285664e1ec2
Can the call to task_io_account_cancelled_write() simply be removed from cancel_dirty_page() for testing the patch with 2.6.19 (since 2.6.19 doesn't seem to have the task I/O accounting) ?
Gordon
-- Gordon Farquharson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |