lkml.org 
[lkml]   [2006]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] Patch: dynticks: idle load balancing
On Tue, Dec 19, 2006 at 09:12:48PM +0100, Ingo Molnar wrote:
> restart:
> if (idle_cpu(local_cpu) && notick.load_balancer == local_cpu) {
> this_cpu = first_cpu(cpus);
> + if (unlikely(this_cpu >= NR_CPUS))
> + return;

oops.

There is window when local_cpu is cleared from notick.cpumask
but the notick.load_balancer still points to local_cpu..
This can also be corrected by first resetting the notick.load_balancer
before clearing that cpu from notick.cpumask in select_notick_load_balancer()

thanks,
suresh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-19 22:53    [W:0.050 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site