lkml.org 
[lkml]   [2006]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.19 file content corruption on ext3
    Peter Zijlstra wrote:
    > On Tue, 2006-12-19 at 02:32 -0800, Andrew Morton wrote:

    >>Well it used to be. After 2.6.19 it can do the wrong thing for mapped
    >>pages. But it turns out that we don't feed it mapped pages, apart from
    >>pagevec_strip() and possibly races against pagefaults.
    >
    >
    > So how about this:

    Well that's still racy. Anyway several earlier patches (including
    the one I posted) closed this race. Some were still reported to
    trigger corruption IIRC.

    > Index: linux-2.6-git/mm/page-writeback.c
    > ===================================================================
    > --- linux-2.6-git.orig/mm/page-writeback.c 2006-12-19 08:24:48.000000000 +0100
    > +++ linux-2.6-git/mm/page-writeback.c 2006-12-19 11:43:31.000000000 +0100
    > @@ -859,6 +859,9 @@ int test_clear_page_dirty(struct page *p
    > struct address_space *mapping = page_mapping(page);
    > unsigned long flags;
    >
    > + if (page_mapped(page))
    > + return 0;
    > +
    > if (!mapping)
    > return TestClearPageDirty(page);
    >
    >
    >
    > -

    --
    SUSE Labs, Novell Inc.
    Send instant messages to your online friends http://au.messenger.yahoo.com

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-19 12:01    [W:4.132 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site