lkml.org 
[lkml]   [2006]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/12] signal: Rewrite kill_something_info so it uses newer helpers.
    Date
    The goal is to remove users of the old signal helper functions
    so they can be removed.

    Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
    ---
    kernel/signal.c | 12 ++++++++----
    1 files changed, 8 insertions(+), 4 deletions(-)

    diff --git a/kernel/signal.c b/kernel/signal.c
    index 1921ffd..1e34d32 100644
    --- a/kernel/signal.c
    +++ b/kernel/signal.c
    @@ -1192,8 +1192,10 @@ EXPORT_SYMBOL_GPL(kill_pid_info_as_uid);

    static int kill_something_info(int sig, struct siginfo *info, int pid)
    {
    + int ret;
    + rcu_read_lock();
    if (!pid) {
    - return kill_pg_info(sig, info, process_group(current));
    + ret = kill_pgrp_info(sig, info, task_pgrp(current));
    } else if (pid == -1) {
    int retval = 0, count = 0;
    struct task_struct * p;
    @@ -1208,12 +1210,14 @@ static int kill_something_info(int sig, struct siginfo *info, int pid)
    }
    }
    read_unlock(&tasklist_lock);
    - return count ? retval : -ESRCH;
    + ret = count ? retval : -ESRCH;
    } else if (pid < 0) {
    - return kill_pg_info(sig, info, -pid);
    + ret = kill_pgrp_info(sig, info, find_pid(-pid));
    } else {
    - return kill_proc_info(sig, info, pid);
    + ret = kill_pid_info(sig, info, find_pid(pid));
    }
    + rcu_read_unlock();
    + return ret;
    }

    /*
    --
    1.4.4.1.g278f
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-13 12:23    [W:9.360 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site