Messages in this thread | | | Subject | Re: + clocksource-add-generic-sched_clock.patch added to -mm tree | From | Thomas Gleixner <> | Date | Sun, 08 Oct 2006 16:51:52 +0200 |
| |
On Sun, 2006-10-08 at 07:45 -0700, Daniel Walker wrote: > On Sun, 2006-10-08 at 11:55 +0200, Thomas Gleixner wrote: > > On Fri, 2006-10-06 at 18:53 -0700, akpm@osdl.org wrote: > > > Adds a generic sched_clock, along with a boot time override for the scheduler > > > clocksource (sched_clocksource). Hopefully the config option would eventually > > > be removed. > > > > Again, this belongs into the clocksource code and not into sched.c > > > > Your patch series scatters clock source related code snippets all over > > the place. This becomes simply a maintenance nightmare. > > It's an API, it's suppose to be used in different places.
Err. clocksource is an API and it is supposed to be at a place, where clocksource code is.
sched_clock is a user of the clocksource API and there is absolutely no reason to put that into sched.c
tglx
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |