lkml.org 
[lkml]   [2006]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/4] gfs2: ->readpages() fixes
From
Date
Hi,

On Tue, 2006-10-31 at 05:05 +0900, OGAWA Hirofumi wrote:
> This just ignore the remaining pages, and remove unneeded unlock_pages().
>
> Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>

Thanks for fixing this,

Steve.


> ---
>
> fs/gfs2/ops_address.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff -puN fs/gfs2/ops_address.c~readpages-fixes-gfs2 fs/gfs2/ops_address.c
> --- linux-2.6/fs/gfs2/ops_address.c~readpages-fixes-gfs2 2006-10-31 04:26:20.000000000 +0900
> +++ linux-2.6-hirofumi/fs/gfs2/ops_address.c 2006-10-31 04:26:20.000000000 +0900
> @@ -337,13 +337,6 @@ out:
> out_noerror:
> ret = 0;
> out_unlock:
> - /* unlock all pages, we can't do any I/O right now */
> - for (page_idx = 0; page_idx < nr_pages; page_idx++) {
> - struct page *page = list_entry(pages->prev, struct page, lru);
> - list_del(&page->lru);
> - unlock_page(page);
> - page_cache_release(page);
> - }
> if (do_unlock)
> gfs2_holder_uninit(&gh);
> goto out;
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-31 09:55    [W:0.054 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site