Messages in this thread | | | Date | Mon, 30 Oct 2006 08:01:42 -0500 | From | "Dave Neuer" <> | Subject | Re: [RFT/PATCH] i8042: remove polling timer (v6) |
| |
On 10/30/06, Vojtech Pavlik <vojtech@suse.cz> wrote: > On Sun, Oct 29, 2006 at 10:34:00PM -0500, Dmitry Torokhov wrote: > > Hi Dave, > > > > i8042_interrupt() uses spinlock to serialize access to the KBC so if real > > interrupt happens before we call i8042_interrupt() manually (and it should > > normally happen) it will just process the response and second i8042_interrupt() > > will be just a no-op. > > This would, however, create two reads of the i8042 controller > back-to-back, which has been a problem on old i8042's: IIRC IBM > documentation states that between the reads there should be a delay. >
Maybe I'm missing something, (well actually I'm sure I'm missing somethng). Looking at the code again, it's unclear to me why there is even a call to the ISR in i8042_aux_write, since the latter function already calls i8042_read_data.
Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |