Messages in this thread | | | Subject | Re: [PATCH v2] Re: Battery class driver. | From | David Woodhouse <> | Date | Sat, 28 Oct 2006 13:15:54 +0100 |
| |
On Thu, 2006-10-26 at 01:39 +0200, Shem Multinymous wrote: > > They're simple enough to add. We can do it when the tp driver gets > > converted over. > > Sure. But It will require some thought. For example, the interface > will need to encompass the non-symmetric pair of force commands on > ThinkPads: > "discharge the battery until further notice" vs. > "don't charge the battery for N minutes". > > Also, ThinkPads express the start/stop charging thresholds in > percent, whereas I imagine some other hardware will represent it as > capacity.
Hm. Again we have the question of whether to export 'threshold_pct' vs. 'threshold_abs', or whether to have a separate string property which says what the 'unit' of the threshold is. I don't care much -- I'll do whatever DavidZ prefers.
The git tree now has support for battery information available from the PMU on Apple laptops. I _really_ don't like the way I have to register a fake platform_device just to be able to get sensible attribute callbacks. I suspect it should go back to being a class_device and we should fix the class_device attribute functions. Greg?
-- dwmw2
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |