Messages in this thread | | | Date | Sat, 28 Oct 2006 23:05:09 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v2] Re: Battery class driver. |
| |
On Sat 2006-10-28 15:53:56, David Zeuthen wrote: > On Sat, 2006-10-28 at 18:55 +0000, Pavel Machek wrote: > > Bad idea... I bet someone will just ignore the units part, because all > > the machines he seen had mW there. > > Sure, user space can do silly things. Just ask davej. Let's try to > assume they don't. > > > Just put it into the name: > > > > power_avg_mV > > Bad idea... it means user space will have to try to open different files > and what happens when someone introduces a new unit? Ideally I'd like > the unit to be part of the payload of the sysfs file. Second to that I > think having the unit in a separate file is preferable.
Introducing new unit *should* be hard. You know, when you introduce new unit, you automatically break all the userspace.
Having separate files is actually a *feature*. It allows you to introduce new units while providing backwards compatibility.
Imagine going from mV to uV... With voltage_mV, you can have both voltage_mV and voltage_uV. In your system, you'd have to change value from mV to uV, breaking all the userspace.... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |