Messages in this thread | | | Date | Thu, 26 Oct 2006 12:25:30 +0200 | From | Harald Welte <> | Subject | Re: [PATCH] cm4000_cs: fix return value check |
| |
On Wed, Oct 25, 2006 at 10:40:04PM -0400, Dominik Brodowski wrote:
> On Tue, Oct 17, 2006 at 03:25:59PM +0900, Akinobu Mita wrote: > > The return value of class_create() need to be checked with IS_ERR(). > > And register_chrdev() returns errno on failure. > > This patch includes these fixes for cm4000_cs and cm4040_cs. > > > > Cc: Harald Welte <laforge@gnumonks.org> > > Signed-off-by: Akinbou Mita <akinobu.mita@gmail.com> > > Temporarily applied to pcmica-2.6.git, thanks. Harald, do you ACK?
yes, sorry. I've been too busy and the mail slipped through...
The patch is obviously fine. Thanks!
Signed-off-by: Harald Welte <laforge@gnumonks.org>
-- - Harald Welte <laforge@gnumonks.org> http://gnumonks.org/ ============================================================================ We all know Linux is great...it does infinite loops in 5 seconds. -- Linus [unhandled content-type:application/pgp-signature] | |