lkml.org 
[lkml]   [2006]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] pvrusb2: use NULL instead of 0
Date
From
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix sparse NULL usage warnings:
> drivers/media/video/pvrusb2/pvrusb2-v4l2.c:714:14: warning: Using plain integer as NULL pointer
> drivers/media/video/pvrusb2/pvrusb2-v4l2.c:715:16: warning: Using plain integer as NULL pointer
> drivers/media/video/pvrusb2/pvrusb2-v4l2.c:1079:10: warning: Using plain integer as NULL pointer
> drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c:224:58: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c | 2 +-
> drivers/media/video/pvrusb2/pvrusb2-v4l2.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> --- linux-2.6.19-rc2-git8.orig/drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c
> +++ linux-2.6.19-rc2-git8/drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c
> @@ -221,7 +221,7 @@ static unsigned int decoder_describe(str
> static void decoder_reset(struct pvr2_v4l_cx2584x *ctxt)
> {
> int ret;
> - ret = pvr2_i2c_client_cmd(ctxt->client,VIDIOC_INT_RESET,0);
> + ret = pvr2_i2c_client_cmd(ctxt->client,VIDIOC_INT_RESET,NULL);

Should be, per Coding-style:

ret = pvr2_i2c_client_cmd(ctxt->client, VIDIOC_INT_RESET, NULL);

There is more similar stuff in the patch. Why not clean that up in the
same sweep?
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria +56 32 2654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 2797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-24 16:37    [W:0.051 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site