Messages in this thread | | | Date | Fri, 20 Oct 2006 14:09:31 -0700 | From | Auke Kok <> | Subject | Re: [PATCH] e100_shutdown: netif_poll_disable hang |
| |
Auke Kok wrote: > Daniel Walker wrote: >> My machine annoyingly hangs while rebooting. I tracked it down >> to e100-fix-reboot-f-with-netconsole-enabled.patch in 2.6.18-rc2-mm2 >> >> I review the changes and it seemed to be calling netif_poll_disable >> one too many time. Once in e100_down(), and again in e100_shutdown(). >> >> The second one in e100_shutdown() caused the hang. So this patch >> removes it.
it doesn't even do harm to netif_poll_disable() twice as far as I can see, as it merely calls test_and_set_bit(), which will instantly succeed on the first attempt if the bit was already set.
did this change actually fix it for you? I'm wondering if the netif_carrier_off might not be the culprit here...
Auke - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |