Messages in this thread | | | Date | Fri, 20 Oct 2006 14:08:59 -0700 (PDT) | Subject | Re: [PATCH 2/3] netpoll: rework skb transmit queue | From | David Miller <> |
| |
From: Andi Kleen <ak@suse.de> Date: Fri, 20 Oct 2006 23:01:29 +0200
> netpoll always played a little fast'n'lose with various locking rules.
The current code is fine, it never reenters ->poll, because it maintains a "->poll_owner" which it checks in netpoll_send_skb() before trying to call back into ->poll.
Every call to ->poll first sets ->poll_owner to the current cpu id. netpoll_send_skb() aborts and does a drop if ->poll_owner is set to the current smp_processor_id().
I sometimes feel like I'm the only person actually reading the sources and past threads on this topic before replying. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |