lkml.org 
[lkml]   [2006]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [NFS] [PATCH 07/11] NFS: fix minor bug in new NFS symlink code
On 10/20/06, Andrew Morton <akpm@osdl.org> wrote:
> On Thu, 19 Oct 2006 13:04:32 -0400
> Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
>
> > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> > index 58d4405..c86a1ea 100644
> > --- a/fs/nfs/dir.c
> > +++ b/fs/nfs/dir.c
> > @@ -1519,8 +1519,8 @@ static int nfs_symlink(struct inode *dir
> > pagevec_init(&lru_pvec, 0);
> > if (!add_to_page_cache(page, dentry->d_inode->i_mapping, 0,
> > GFP_KERNEL)) {
> > - if (!pagevec_add(&lru_pvec, page))
> > - __pagevec_lru_add(&lru_pvec);
> > + pagevec_add(&lru_pvec, page);
> > + pagevec_lru_add(&lru_pvec);
> > SetPageUptodate(page);
> > unlock_page(page);
> > } else
>
> One could export add_to_page_cache_lru() to modules..

I assumed there was probably a good reason that this had not already been done.

--
"We who cut mere stones must always be envisioning cathedrals"
-- Quarry worker's creed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-20 07:01    [W:0.140 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site