Messages in this thread | | | Date | Wed, 18 Oct 2006 10:08:10 -0500 | From | Corey Minyard <> | Subject | Re: [IPMI] Fix return codes in failure case. |
| |
Thanks, looks good.
-Corey
Dave Jones wrote: > These returns should be negative, like the others in this function. > > Signed-off-by: Dave Jones <davej@redhat.com> > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 24825bd..e5cfb1f 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -1789,7 +1789,7 @@ static int __devinit ipmi_pci_probe(stru > > info = kzalloc(sizeof(*info), GFP_KERNEL); > if (!info) > - return ENOMEM; > + return -ENOMEM; > > info->addr_source = "PCI"; > > @@ -1810,7 +1810,7 @@ static int __devinit ipmi_pci_probe(stru > kfree(info); > printk(KERN_INFO "ipmi_si: %s: Unknown IPMI type: %d\n", > pci_name(pdev), class_type); > - return ENOMEM; > + return -ENOMEM; > } > > rv = pci_enable_device(pdev); > >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |