lkml.org 
[lkml]   [2006]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1 of 2] fsstack: Introduce fsstack_copy_{attr,inode}_*
On Tue, Oct 17, 2006 at 12:40:31PM +0200, Jan Engelhardt wrote:
>
> >To: null@josefsipek.net
>
> (Superb idea to prekill any Cc, re-adding them)

Yeah, I like to test the emails but I accidentally sent them. From now on,
no testing :)

> >+void __fsstack_copy_attr_all(struct inode *dest,
> >+ const struct inode *src,
> >+ int (*get_nlinks)(struct inode *))
> >+{
> >[big]
> >+}
> >+
> >+/* externs for fs/stack.c */
> >+extern void __fsstack_copy_attr_all(struct inode *dest,
> >+ const struct inode *src,
> >+ int (*get_nlinks)(struct inode *));
> >+
> >+static inline void fsstack_copy_attr_all(struct inode *dest,
> >+ const struct inode *src)
> >+{
> >+ __fsstack_copy_attr_all(dest, src, NULL);
> >+}
>
> Do we really need this indirection? Can't __fsstack_copy_attr_all be
> named fsstack_copy_attr_all instead?

I suppose it could. There is no API-breakage to avoid.

Josef "Jeff" Sipek.

--
Computer Science is no more about computers than astronomy is about
telescopes.
- Edsger Dijkstra
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-17 22:37    [W:0.060 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site