Messages in this thread | | | Date | Tue, 17 Oct 2006 15:43:22 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [Patch 4/4] Driver core: Don't fail attaching the device if it cannot be bound. |
| |
On Tue, 17 Oct 2006, Cornelia Huck wrote:
> On Tue, 17 Oct 2006 12:04:28 -0400 (EDT), > Alan Stern <stern@rowland.harvard.edu> wrote:
> > It looks odd to test the value of ret when you've just crashed the system > > if ret < 0. You probably should change the BUG_ON to a WARN_ON or > > something similar. > > OK, WARN_ON is probably better (but it should never happen anyway). > Updated patch below.
Yes, I like this one better.
Alan Stern
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |