Messages in this thread | | | Date | Sun, 15 Oct 2006 20:16:55 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 2/2] 2.6.19-rc1-mm1 pktcdvd: bio write congestion |
| |
On Sat, Oct 14 2006, Peter Osterlund wrote: > "Thomas Maier" <balagi@justmail.de> writes: > > > Hello, > > > > this adds a bio write queue congestion control > > to the pktcdvd driver with fixed on/off marks. > > It prevents that the driver consumes a unlimited > > amount of write requests. > > Thanks, this looks good in principle, but I think it can be > implemented in a simpler way. > > Jens, can I please ask your opinion. Would it make sense to export the > clear_queue_congested() and set_queue_congested() functions in > ll_rw_blk.c so that the pktcdvd driver can use them? Something like > this patch from a few years ago: > > http://marc.theaimsgroup.com/?l=linux-kernel&m=109378210610508&w=2
It definitely would. Did you test, and did it work well for you? I think it's the right approach.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |