Messages in this thread | | | Date | Sun, 15 Oct 2006 17:57:27 +0200 | From | Nick Piggin <> | Subject | RRe: [patch 6/6] mm: fix pagecache write deadlocks |
| |
On Sun, Oct 15, 2006 at 05:47:03PM +0200, Peter Zijlstra wrote: > > > > And we should really decouple it from preempt entirely, in case we > > ever want to check for it some other way in the pagefault handler. > > How about we make sure all kmap_atomic implementations behave properly > and make in_atomic true.
Hmm, but you may not be doing a copy*user within the kmap. And you may want an atomic copy*user not within a kmap (maybe).
I think it really would be more logical to do it in a wrapper function pagefault_disable() pagefault_enable()? ;)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |