Messages in this thread | | | Date | Thu, 12 Oct 2006 17:50:13 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] sk98lin: handle pci_enable_device() return value in skge_resume() properly |
| |
On Fri, 13 Oct 2006 00:57:18 +0200 (CEST) Jiri Kosina <jikos@jikos.cz> wrote:
> @@ -5070,7 +5070,13 @@ static int skge_resume(struct pci_dev *p > > pci_set_power_state(pdev, PCI_D0); > pci_restore_state(pdev); > - pci_enable_device(pdev); > + ret = pci_enable_device(pdev); > + if (ret) { > + printk(KERN_ERR "sk98lin: Cannot enable PCI device %s during resume\n", > + dev->name); > + unregister_netdev(dev);
This looks rather wrong - skge_exit() will run unregister_netdev() again.
Look a few lines down, to where this function already handles request_irq() failure, reuse that code path. Hopefully it has been tested..
(Once we have an easy-to-use fault-injection framework we'll be able to test all these things more easily)
(But it's possible to test them already, with a bit of ad-hoc testing code) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |