Messages in this thread | | | Date | Fri, 13 Oct 2006 02:39:26 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] fix parport_serial_pci_resume() ignoring return value from pci_enable_device() |
| |
On Fri, 13 Oct 2006, Russell King wrote:
> I suspect all these kind of patches are introducing additional problems. > This one certainly is. Who's auditing all these patches? I mean _properly_ > auditing them rather than just saying "that's a good idea"?
For the fm801 gameport case it is fine - it's just one more check in the _probe() function, performing the same error path as other cases do.
ALSA case has already been solved by calling snd_card_disconnect() on error path.
But I agree that sk98lin and parport_serial_pci patches are likely broken.
Thanks,
-- Jiri Kosina - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |