Messages in this thread | | | Date | Thu, 12 Oct 2006 14:03:23 -0700 | From | Andrew Morton <> | Subject | Re: [patch 2/7] fault-injection capabilities infrastructure |
| |
On Thu, 12 Oct 2006 16:43:07 +0900 Akinobu Mita <akinobu.mita@gmail.com> wrote:
> From: Akinobu Mita <akinobu.mita@gmail.com> > > This patch provides base functions for implement fault-injection > capabilities. > > - Lightweight random simulator is taken from crasher module for SUSE kernel
heh, another one.
Please switch over to carta_random32() for now. Later we'll probably be removing carta_random32() and adding random32(), but I can take care of that.
> +#define failure_probability(attr) (attr)->probability > +#define failure_interval(attr) (attr)->interval > +#define max_failures(attr) (attr)->times > +#define current_space(attr) (attr)->space > +#define atomic_dec_not_zero(v) atomic_add_unless((v), -1, 0)
Please remove these macros and simply open-code these operations at each callsite.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |