lkml.org 
[lkml]   [2006]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 66/67] NETFILTER: NAT: fix NOTRACK checksum handling
    -stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Patrick McHardy <kaber@trash.net>

    The whole idea with the NOTRACK netfilter target is that
    you can force the netfilter code to avoid connection
    tracking, and all costs assosciated with it, by making
    traffic match a NOTRACK rule.

    But this is totally broken by the fact that we do a checksum
    calculation over the packet before we do the NOTRACK bypass
    check, which is very expensive. People setup NOTRACK rules
    explicitly to avoid all of these kinds of costs.

    This patch from Patrick, already in Linus's tree, fixes the
    bug.

    Move the check for ip_conntrack_untracked before the call to
    skb_checksum_help to fix NOTRACK excemptions from NAT. Pre-2.6.19
    NAT code breaks TSO by invalidating hardware checksums for every
    packet, even if explicitly excluded from NAT through NOTRACK.

    2.6.19 includes a fix that makes NAT and TSO live in harmony,
    but the performance degradation caused by this deserves making
    at least the workaround work properly in -stable.

    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/ipv4/netfilter/ip_nat_standalone.c | 11 ++++++-----
    1 file changed, 6 insertions(+), 5 deletions(-)

    --- linux-2.6.18.orig/net/ipv4/netfilter/ip_nat_standalone.c
    +++ linux-2.6.18/net/ipv4/netfilter/ip_nat_standalone.c
    @@ -110,12 +110,17 @@ ip_nat_fn(unsigned int hooknum,
    IP_NF_ASSERT(!((*pskb)->nh.iph->frag_off
    & htons(IP_MF|IP_OFFSET)));

    + ct = ip_conntrack_get(*pskb, &ctinfo);
    +
    + /* Don't try to NAT if this packet is not conntracked */
    + if (ct == &ip_conntrack_untracked)
    + return NF_ACCEPT;
    +
    /* If we had a hardware checksum before, it's now invalid */
    if ((*pskb)->ip_summed == CHECKSUM_HW)
    if (skb_checksum_help(*pskb, (out == NULL)))
    return NF_DROP;

    - ct = ip_conntrack_get(*pskb, &ctinfo);
    /* Can't track? It's not due to stress, or conntrack would
    have dropped it. Hence it's the user's responsibilty to
    packet filter it out, or implement conntrack/NAT for that
    @@ -137,10 +142,6 @@ ip_nat_fn(unsigned int hooknum,
    return NF_ACCEPT;
    }

    - /* Don't try to NAT if this packet is not conntracked */
    - if (ct == &ip_conntrack_untracked)
    - return NF_ACCEPT;
    -
    switch (ctinfo) {
    case IP_CT_RELATED:
    case IP_CT_RELATED+IP_CT_IS_REPLY:
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-11 23:17    [W:2.269 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site