lkml.org 
[lkml]   [2006]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: misused local_irq_disable() in analog.c?
On Wed, 11 Oct 2006 16:17:33 -0400 Dmitry Torokhov wrote:

> On 10/11/06, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > Dmitry, take a look at analog_cooked_read():
> >
> > do-while loop there contains local_irq_disable()/local_irq_restore(flags);
> > which aren't complement.
> >
> > Should it be
> >
> > local_irq_save(flags);
> > this = gameport_read(gameport) & port->mask;
> > GET_TIME(now);
> > local_irq_restore(flags);
> >
> > ?
>
> Yep, I think so. Patch?

Alexey replied on another thread (Re: [PATCH] misuse of strstr):

"sorry for absence of patch, I'm on wonders of BY dial-up _and_ Gmail
web interface right now."


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-11 22:35    [W:0.027 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site