Messages in this thread | | | Subject | Re: [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug(). | From | Arjan van de Ven <> | Date | Tue, 10 Oct 2006 13:31:23 +0200 |
| |
On Tue, 2006-10-10 at 07:17 -0400, Robert P. J. Day wrote: > Simplify the definition of IXGB_DBG() to be based on pr_debug(). > > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com> > --- > diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h > index 50ffe90..16e6c3d 100644 > --- a/drivers/net/ixgb/ixgb.h > +++ b/drivers/net/ixgb/ixgb.h > @@ -77,11 +77,7 @@ #include "ixgb_hw.h" > #include "ixgb_ee.h" > #include "ixgb_ids.h" > > -#ifdef _DEBUG_DRIVER_ > -#define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args) > -#else > -#define IXGB_DBG(args...) > -#endif > +#define IXGB_DBG(args...) pr_debug("ixgb: ", args)
while this is of course correct, why not go all the way and replace all IXGB() users to pr_debug() directly?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |