lkml.org 
[lkml]   [2006]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hwmon/abituguru: handle sysfs errors


Jean Delvare wrote:
> Hi Hans, Jeff,
>
>> You (Jean) already mailed me about this and it was on my todo list,
>> but I'm currently rather busy with work. So it looks like Jeff beat
>> me to it.
>>
>> Jeff's patch looks fine, please apply. Thanks Jeff!
>
> The patch isn't wrong per se, but it could be made more simple, and is
> incomplete in comparison to what was done for all other hardware
> monitoring drivers:
>
> * We want to create all the files before registering with the hwmon
> class, this closes a race condition.

OK

> * We want to delete all the device files at regular cleanup time (after
> unregistering with the hwmon class).

Is this really nescesarry? AFAIK the files get deleted when the device gets deleted.

> * It's OK to call device_create_file() on a non-existent file, so the
> error path can be simplified.
>

?? You mean device_remove_file I assume?

> I'd like the abituguru driver to behave the same as all other hardware
> monitoring drivers to lower the maintenance effort. Can either you
> or Jeff work up a compliant patch?
>

I understand Jeff any chance you can do a new revision of your patch? Otherwise I'll take care of it as time permits.

Regards,

Hans
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-10 11:23    [W:0.129 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site