Messages in this thread | | | Date | Wed, 11 Oct 2006 02:43:33 +0200 | From | Nick Piggin <> | Subject | Re: SPAM: Re: [patch 3/3] mm: fault handler to replace nopage and populate |
| |
On Tue, Oct 10, 2006 at 10:52:36AM -0700, Andrew Morton wrote: > On Tue, 10 Oct 2006 14:13:27 +0200 > Nick Piggin <npiggin@suse.de> wrote: > > > > Hmm... I agree it is more consistent, but OTOH if we're passing a > > structure I thought it may as well just go in there. But I will > > change unless anyone comes up with an objection. > > I'd agree that it's more attractive to have the vma* in the argument list, > but it presumably adds runtime cost: cycles and stack depth. I don't how > much though.
Possibly, though I considered it might end up in a register, and considering that the vma is used both before and after the call, and in filemap_nopage, it's quite possible that it saves a load and does not harm stack depth. Maybe?
I don't know, I guess we can tweak it while it is in -mm? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |