lkml.org 
[lkml]   [2006]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] firmware/dell_rbu: handle sysfs errors


    Signed-off-by: Jeff Garzik <jeff@garzik.org>

    ---

    drivers/firmware/dell_rbu.c | 21 +++++++++++++++++----
    1 file changed, 17 insertions(+), 4 deletions(-)

    3ee9d835887cc49e747f3b39e7d8623918457e3d
    diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c
    index fc17599..4fb5d72 100644
    --- a/drivers/firmware/dell_rbu.c
    +++ b/drivers/firmware/dell_rbu.c
    @@ -718,14 +718,27 @@ static int __init dcdrbu_init(void)
    return -EIO;
    }

    - sysfs_create_bin_file(&rbu_device->dev.kobj, &rbu_data_attr);
    - sysfs_create_bin_file(&rbu_device->dev.kobj, &rbu_image_type_attr);
    - sysfs_create_bin_file(&rbu_device->dev.kobj,
    + rc = sysfs_create_bin_file(&rbu_device->dev.kobj, &rbu_data_attr);
    + if (rc)
    + goto out_devreg;
    + rc = sysfs_create_bin_file(&rbu_device->dev.kobj, &rbu_image_type_attr);
    + if (rc)
    + goto out_data;
    + rc = sysfs_create_bin_file(&rbu_device->dev.kobj,
    &rbu_packet_size_attr);
    + if (rc)
    + goto out_imtype;

    rbu_data.entry_created = 0;
    - return rc;
    + return 0;

    +out_imtype:
    + sysfs_remove_bin_file(&rbu_device->dev.kobj, &rbu_image_type_attr);
    +out_data:
    + sysfs_remove_bin_file(&rbu_device->dev.kobj, &rbu_data_attr);
    +out_devreg:
    + platform_device_unregister(rbu_device);
    + return rc;
    }

    static __exit void dcdrbu_exit(void)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-10-10 08:59    [W:3.405 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site