Messages in this thread | | | Date | Mon, 9 Jan 2006 20:49:35 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: [PATCH RT] make hrtimer_nanosleep return immediately if time has passed |
| |
On Mon, 9 Jan 2006, George Anzinger wrote: > Steven Rostedt wrote: > > Uh... I have been wondering about the "mode" thing, thinking "flags" might be > better. And allowing, say, a "return if elapsed" flag as well as the ABS > flag. Then all you would need to do is to add the "return if elapsed" flag > to the nanosleep calls. I have other reasons for wanting to expand the > "mode" to more that two states... but, even with out that, I think the result > would be a) less code, and b) easier to follow and understand. I just have > trouble pushing a word on the stack to make a call and then use only one bit > of it when it could be combined...
And I perfectly agree with you :)
The problem is that the hrtimes is not my code, and I don't like doing too many changes in code that I don't understand the consequences of. As you showed me earlier, that the previous change broke the posix_timers. So I really only did the bare minimum to fix what I considered a bug, and let Thomas, John, Ingo or yourself do a proper fix. Someone that understands the timers better than I do.
Currently, it seems those people are too busy, and I just wanted a quick fix. I personally didn't like the patch, but my nose is stuck more into the scheduling, memory and Ingo's rt_mutex now to spend time understanding all the timer code. ;)
> > Never the less, the following code looks like is does the right thing. >
This was all I asked for.
Thanks,
-- Steve
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |