Messages in this thread | | | Date | Mon, 09 Jan 2006 12:32:51 -0500 | From | Jeff Mahoney <> | Subject | Re: [PATCH] ia64: including <asm/signal.h> alone causes compilation errors |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Christoph Hellwig wrote: > On Mon, Jan 09, 2006 at 12:15:14PM -0500, Jeff Mahoney wrote: >> Including *just* <asm/signal.h> on ia64 will result in a compilation failure, >> where it will succeed on every other architecture. >> >> Every other arch includes <linux/compiler.h> either directly or via >> <linux/types.h> at the top of <asm-*/signal.h>. ia64 includes >> <linux/types.h> after including <asm-generic/signal.h>, which causes >> the __user in <asm-generic/signal.h> to get passed through untouched, causing >> compilation errors. >> >> This patch moves the #include <linux/types.h> up to the beginning of signal.h, >> as found on every other arch. >> >> A specific example of where this behavior is observed is the recent addition >> of OCFS2. fs/ocfs2/cluster/userdlm.c seems alone in only including >> <asm/signal.h>, which seems to be perfectly valid. > > Generally you should only include <asm/signal.h> via <linux/signal.h>, which gets > <linux/compiler.h> via <linux/spinlock.h>
Ok. I just did a quick grep and saw a number of places where <asm/signal.h> was included. A closer look reveals most of those are in arch/.
Ignore the noise.
- -Jeff
- -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFDwp5DLPWxlyuTD7IRAoZBAKCf4MMQNC/rfcdXOH0Dto3RTa32qgCfSeFf pX68kyrbj2ZdH23Mo+EmUZ4= =y7xp -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |