lkml.org 
[lkml]   [2006]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] rcu: don't check ->donelist in __rcu_pending()
    On Mon, Jan 09, 2006 at 05:51:08PM +0300, Oleg Nesterov wrote:
    > Srivatsa Vaddagiri wrote:
    > > If we have to do a rcu_move_batch of ->donelist also,
    > > then perhaps the ->donelist != NULL check is required in
    > > rcu_pending?
    >
    > rcu_move_batch() always adds entries to the ->nxttail, so I think
    > this patch is correct.

    Hmm ..adding entries on dead cpu's ->donelist to ->nxtlist of some other CPU
    doesnt make sense (it re-triggers graceperiods for all those callbacks which is
    not needed). Maybe rcu_move_batch should take that into account and instead add
    to ->donelist of current CPU which is processing the CPU_DEAD callback.

    In which case, ->donelist != NULL check is still reqd in rcu_pending ?


    --


    Thanks and Regards,
    Srivatsa Vaddagiri,
    Linux Technology Center,
    IBM Software Labs,
    Bangalore, INDIA - 560017
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-09 14:45    [W:5.713 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site