Messages in this thread | | | Date | Sun, 8 Jan 2006 19:30:57 -0800 | From | Greg KH <> | Subject | Re: [GIT PATCH] PCI patches for 2.6.15 |
| |
On Mon, Jan 09, 2006 at 01:44:18PM +1100, Benjamin Herrenschmidt wrote: > > > Hi Greg, what patches specifically have problems ? Paul is just back > > from vacation and we are trying to catch up with merging the tons of > > pending powerpc stuffs, but we have a couple of requirements with things > > in this list, notably my small export of pci_cfg_space_size() which > > should be trivial, but also Linas error recovery stuff... So if one of > > these is causing problems, we need to know right now as it means we have > > to rebase. > > BTW. I looked a linux-pci and only saw 2 complaints about the e1000 and > sym2 driver patches to implement error recovery. I suppose you could > just drop those 2 and keep the infrastructure in. However, I'm a bit > annoyed because Linas did post those patches (and several times I think) > to the relevant lists, and possibly the maintainers (not sure about > that) and no comment was ever made...
I also got complaints about a number of the pci_register_driver() changes, and I was reminded that some of the other patches break some big IBM boxes in bad ways.
> I find it fairly annoying (and that's not the first time that happens) > that a major piece of work gets posted publically several times, nobody > bothers to comment, and by the time it gets send for merging upstream, > suddenly, people wakeup from all over the place NAK'ing it for all sort > of reasons, mostly claiming it wasn't properly reviewed by the > appropriate maintainers...
Heh, it's not the first time, and will not be the last :)
I'll be reposting the series to Linus tomorrow. I'll include your export patch, and the core pci error handling changes, so you don't need to worry about your tree.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |