lkml.org 
[lkml]   [2006]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/15] kconf: Check for eof from input stream.
On Sun, 2006-01-08 at 21:59 +0100, Roman Zippel wrote:
> Hi,
>
> On Sun, 8 Jan 2006, Ben Collins wrote:
>
> > Anyway, the problem is that if there is no terminal (e.g. stdout is
> > redirected to a file, and stdin is closed), then kconf loops forever
> > trying to get an answer (NULL is not the same as "").
>
> Then let's fix the real problem.

That's not entirely acceptable. The reason this shows up is if an
automatic build is being done, and the config files are not up-to-date,
the prefered action is a build failure, not selecting defaults. The
reason for my fix was that instead of filling up diskspace with a
logfile of kconf's infinite loop, we just exit with an error.

Currently, this is the only way to ensure that these issues don't go
unnoticed.

--
Ben Collins <ben.collins@ubuntu.com>
Developer
Ubuntu Linux

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-01-08 22:47    [W:0.061 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site