lkml.org 
[lkml]   [2006]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/16] mm: remove unnecessary variable and loop
    On Wed, Dec 07, 2005 at 06:48:04PM +0800, Wu Fengguang wrote:
    > shrink_cache() and refill_inactive_zone() do not need loops.
    >
    > Simplify them to scan one chunk at a time.

    Hi Wu,

    What is the purpose of scanning large chunks at a time?

    Some drawbacks that I can think of by doing that:

    - zone->lru_lock will be held for much longer periods, resulting in
    decreased responsiveness and possibly slowdowns.

    - if the task doing the scan is uncapable of certain operations, for
    instance IO, dirty pages will be moved back to the head of the inactive
    list in much larger batches then they were before. This could hurt
    reclaim in general.

    What were the results of this change? Particularly contention on the
    lru_lock on medium-large SMP systems.

    Thanks!
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-05 22:24    [W:4.705 / U:0.756 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site