Messages in this thread | | | Date | Tue, 3 Jan 2006 21:52:16 -0600 | From | Mark Maule <> | Subject | Re: [PATCH 1/3] msi vector targeting abstractions |
| |
On Tue, Jan 03, 2006 at 04:27:38PM -0800, Greg KH wrote: > On Tue, Jan 03, 2006 at 04:20:47PM -0800, Grant Grundler wrote: > > On Tue, Jan 03, 2006 at 05:50:24PM -0600, Mark Maule wrote: > > > > > +struct msi_ops msi_apic_ops = { > > > > > + .setup = msi_setup_apic, > > > > > + .teardown = msi_teardown_apic, > > > > > +#ifdef CONFIG_SMP > > > > > + .target = msi_target_apic, > > > > > +#endif > > > > > > > > Mark, > > > > msi_target_apic() initializes address_lo parameter. > > > > Even on a UP machine, we need inialize this value. > > > > > > Not sure what you mean here. target is used to retarget an existing > > > MSI vector to a different processor. > > > > Right - I didn't realize the caller, set_msi_affinity(), was surrounded by > > "#ifdef CONFIG_SMP". > > > > But set_msi_affinity() appears to be dead code. > > I couldn't find any calls to set_msi_affinity() in 2.6.14 or 2.6.15. > > Greg, you want a patch to remove that? > > Yes please, that would be great to have. > > thanks, > > greg k-h
Is that really dead code? From msi.h:
#ifdef CONFIG_SMP #define set_msi_irq_affinity set_msi_affinity #else #define set_msi_irq_affinity NULL #endif
Mark - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |