Messages in this thread Patch in this message | | | Date | Tue, 3 Jan 2006 10:41:57 -0800 | From | Stephen Hemminger <> | Subject | [PATCH] BRIDGE: Fix faulty check in br_stp_recalculate_bridge_id() |
| |
One of the conversions from memcmp to compare_ether_addr is incorrect. We need to do relative comparison to determine min MAC address to use in bridge id.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- linux-2.6.15.orig/net/bridge/br_stp_if.c +++ linux-2.6.15/net/bridge/br_stp_if.c @@ -158,7 +158,7 @@ void br_stp_recalculate_bridge_id(struct list_for_each_entry(p, &br->port_list, list) { if (addr == br_mac_zero || - compare_ether_addr(p->dev->dev_addr, addr) < 0) + memcmp(p->dev->dev_addr, addr, ETH_ALEN) < 0) addr = p->dev->dev_addr; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |