Messages in this thread | | | Date | Sun, 29 Jan 2006 00:46:55 -0800 | From | Suleiman Souhlal <> | Subject | Re: [PATCH 1/5] pid: Implement task references. |
| |
Eric W. Biederman wrote:
Just a few typos in comments.
> @@ -17,6 +17,8 @@ struct pid > struct hlist_node pid_chain; > /* list of pids with the same nr, only one of them is in the hash */ > struct list_head pid_list; > + /* Does a weak references of this type exsit to the task struct? */ > + struct task_ref *ref;
exsit -> exist
> +/* Note to read a usable value task value from struct task_ref > + * the tasklist_lock must be held. The atomic property of single > + * word reads will keep any vaule you read consistent but it doesn't
vaule -> value
> + * protect you from the race of the task exiting on another cpu and > + * having it's task_struct freed or reused. Holding the tasklist_lock > + * prevents the task from going away as you derference the task pointer.
derference -> dereference
-- Suleiman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |